Skip to content

pin JET to <= 0.10.6 #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

pin JET to <= 0.10.6 #1046

merged 2 commits into from
Sep 19, 2025

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Sep 19, 2025 •
edited
Loading

v0.10.7 has a new method for detecting potentially undefined variables which causes any model with product_distribution([InverseGamma(2, 3), InverseGamma(2, 3)]) to fail JET tests.

See #1040

I'm not sure if it's a JET issue per se but I've reported this at aviatesk/JET.jl#749 and we can see where to go.
(Update: JET is behaving right, I'll report it on SpecialFunctions.)

In the meantime to make CI pass this PR pins JET to <= v0.10.6.

Closes #1040

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

Benchmark Report for Commit 51383c2

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  8.3 |                 1.6 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                654.2 |                42.2 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                428.8 |                52.0 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1206.9 |                29.1 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               6552.2 |                29.8 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1481.8 |                28.4 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |               1010.6 |                 4.5 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5775.3 |                 4.3 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |                982.7 |                 9.1 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              65631.9 |                 3.8 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8536.7 |                10.1 |
|               Dynamic |        10 |    mooncake |             typed |   true |                134.7 |                11.4 |
|              Submodel |         1 |    mooncake |             typed |   true |                 14.1 |                 4.7 |
|                   LDA |        12 | reversediff |             typed |   true |               1207.3 |                 2.3 |

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.34%. Comparing base (3db45ee) to head (51383c2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files          38       38           
  Lines        3949     3949           
=======================================
  Hits         3252     3252           
  Misses        697      697

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm penelopeysm requested a review from mhauru September 19, 2025 16:30
@penelopeysm penelopeysm added this pull request to the merge queue Sep 19, 2025
@penelopeysm penelopeysm removed this pull request from the merge queue due to a manual request Sep 19, 2025
@penelopeysm
Copy link
Member Author

Silly mistake, should pin test dep not the main project dep.

@github-actions GitHub Actions
Copy link
Contributor

DynamicPPL.jl documentation for PR #1046 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1046/

@penelopeysm penelopeysm merged commit e50d40d into main Sep 19, 2025
21 checks passed
@penelopeysm penelopeysm deleted the py/pin-jet branch September 19, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhauru mhauru mhauru approved these changes

Assignees

@penelopeysm penelopeysm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JET 1.12 tests are failing
2 participants
@penelopeysm @mhauru